SR 1.5 #879
Merged
SR 1.5 #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ao into feat/second-opinion-test
test: Second opinion oracle test
# Conflicts: # scripts/scratch/steps/0130-grant-roles.ts # scripts/scratch/steps/0140-plug-staking-modules.ts
…velop-sync # Conflicts: # deployed-holesky.json # deployed-mainnet.json # test/0.8.9/oracle/hashConsensus.setQuorum.test.ts
chore: Sync SR1.5 branch with the latest develop
feat: Staking Router 1.5
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1350
to
+1358
| function _updateModuleLastDepositState( | ||
| StakingModule storage stakingModule, | ||
| uint256 stakingModuleId, | ||
| uint256 depositsValue | ||
| ) internal { | ||
| stakingModule.lastDepositAt = uint64(block.timestamp); | ||
| stakingModule.lastDepositBlock = block.number; | ||
| emit StakingRouterETHDeposited(stakingModuleId, depositsValue); | ||
| } |
Check warning
Code scanning / Slither
Dubious Typecast Medium
Comment on lines
+1503
to
+1505
| function _getStakingModuleSummary(IStakingModule stakingModule) internal view returns (uint256, uint256, uint256) { | ||
| return stakingModule.getStakingModuleSummary(); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: 39caac3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
TheDZhon
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I confirm zero contract changes against the deployed and audited version 🫡
The reference commit hash: 1ffbb7e49e112fcac678f59bf63ba57a7e522874
Audit reports:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StakingRouter 1.5 Upgrade, deployed on mainnet