-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
133 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 1 addition & 5 deletions
6
.../writer/update/CompositeVeniceWriter.java → .../venice/writer/CompositeVeniceWriter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...nal/venice-common/src/test/java/com/linkedin/venice/writer/CompositeVeniceWriterTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package com.linkedin.venice.writer; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyInt; | ||
| import static org.mockito.ArgumentMatchers.eq; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.never; | ||
| import static org.mockito.Mockito.timeout; | ||
| import static org.mockito.Mockito.verify; | ||
|
|
||
| import com.linkedin.venice.exceptions.VeniceException; | ||
| import com.linkedin.venice.pubsub.api.PubSubProduceResult; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.Test; | ||
|
|
||
|
|
||
| public class CompositeVeniceWriterTest { | ||
| @Test | ||
| public void testFlushChecksForLastWriteFuture() { | ||
| VeniceWriter<byte[], byte[], byte[]> mockWriter = mock(VeniceWriter.class); | ||
| CompletableFuture<PubSubProduceResult> mainWriterFuture = new CompletableFuture<>(); | ||
| doReturn(mainWriterFuture).when(mockWriter).put(any(), any(), anyInt(), eq(null)); | ||
| mainWriterFuture.completeExceptionally(new VeniceException("Expected exception")); | ||
| AbstractVeniceWriter<byte[], byte[], byte[]> compositeVeniceWriter = | ||
| new CompositeVeniceWriter("test_v1", mockWriter, new VeniceWriter[0], null); | ||
| compositeVeniceWriter.put(new byte[1], new byte[1], 1, null); | ||
| VeniceException e = Assert.expectThrows(VeniceException.class, compositeVeniceWriter::flush); | ||
| Assert.assertTrue(e.getCause().getMessage().contains("Expected")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testWritesAreInOrder() throws InterruptedException { | ||
| VeniceWriter<byte[], byte[], byte[]> mockMainWriter = mock(VeniceWriter.class); | ||
| CompletableFuture<PubSubProduceResult> mainWriterFuture = CompletableFuture.completedFuture(null); | ||
| doReturn(mainWriterFuture).when(mockMainWriter).put(any(), any(), anyInt(), eq(null)); | ||
| VeniceWriter<byte[], byte[], byte[]> mockChildWriter = mock(VeniceWriter.class); | ||
| CompletableFuture<PubSubProduceResult> childWriterFuture = new CompletableFuture<>(); | ||
| doReturn(childWriterFuture).when(mockChildWriter).put(any(), any(), anyInt(), eq(null)); | ||
| VeniceWriter[] childWriters = new VeniceWriter[1]; | ||
| childWriters[0] = mockChildWriter; | ||
| AbstractVeniceWriter<byte[], byte[], byte[]> compositeVeniceWriter = | ||
| new CompositeVeniceWriter<byte[], byte[], byte[]>("test_v1", mockMainWriter, childWriters, null); | ||
| compositeVeniceWriter.put(new byte[1], new byte[1], 1, null); | ||
| verify(mockMainWriter, never()).put(any(), any(), anyInt(), eq(null)); | ||
| Thread.sleep(1000); | ||
| verify(mockMainWriter, never()).put(any(), any(), anyInt(), eq(null)); | ||
| childWriterFuture.complete(null); | ||
| verify(mockMainWriter, timeout(1000)).put(any(), any(), anyInt(), eq(null)); | ||
| } | ||
| } |