Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fallthroughs explicit in lsqpack.c #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make fallthroughs explicit in lsqpack.c #57

wants to merge 3 commits into from

Commits on Jul 1, 2024

  1. Make fallthroughs explicit in lsqpack.c 

    Using `__attribute__((fallthrough));` informs the compiler, in a way it understands, that the fallthrough is explicit and wanted.

This allows for the enablement of `-Wimplicit-fallthrough`, which throws warnings/errors for implicit fallthroughs, of which several exist in this file. Using `-Wimplicit-fallthrough` prevents unwanted fallthroughs.
    @r-barnes
    r-barnes authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ce4e4ea View commit details
    Browse the repository at this point in the history

  2. Make explicit fallthroughs cross-compiler and readable

    @r-barnes
    r-barnes authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2083135 View commit details
    Browse the repository at this point in the history

  3. Update lsqpack.c

    @r-barnes
    r-barnes authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0a349e3 View commit details
    Browse the repository at this point in the history