Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podtato-head tutorial #302

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suhyenim
Copy link

@suhyenim suhyenim commented Nov 17, 2024

What this PR does / why we need it:
This PR implements two features:

  • Adds Tutorials tab to Litmus Docs.
스크린샷 2024-11-22 오전 4 23 29 스크린샷 2024-11-22 오전 2 19 40

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes tutorial issue on #296

Special notes for your reviewer:

Checklist:

  • Fixes tutorial issue on Remove obsolete websites #296
  • Signed the commit for DCO to be passed
  • Labelled this PR & related issue with documentation tag

Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litmus-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:13pm

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for docs-litmuschaos ready!

Name Link
🔨 Latest commit ff06847
🔍 Latest deploy log https://app.netlify.com/sites/docs-litmuschaos/deploys/673f85292437cb000851f058
😎 Deploy Preview https://deploy-preview-302--docs-litmuschaos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

![setup-probe](../assets/tutorials/podtato-head/setup-probe.png)

## Run Chaos Experiment with Podtato-head
1. For Kubernetes v1.24 or later, bind a ClusterRole to the `argo-chaos` service account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we binding argo-chaos serviceAccount to admin cluster-role?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with Kubernetes v1.24, service accounts no longer receive tokens automatically upon creation. To provide the necessary permissions to the argo-chaos service account, we initially bound it to the admin cluster role. However, since this cluster role grants excessively broad permissions, it would be more appropriate to assign a role specific to the litmus namespace instead.

Additionally, please note that with the recent update to the tutorial, this step is now unnecessary.

@namkyu1999
Copy link
Member

Rather than using the existing template, it would be a good idea to add a brief description of podtato-head and write a tutorial that goes through installing the podtato-head application and experimenting with pod delete. WDYT?

@suhyenim
Copy link
Author

Rather than using the existing template, it would be a good idea to add a brief description of podtato-head and write a tutorial that goes through installing the podtato-head application and experimenting with pod delete. WDYT?

I think it's a great idea! I’ve updated the podtato-head tutorial based on your suggestion. Please check the update.

Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants