Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testpr pwa3248 #4243

Closed
wants to merge 4 commits into from
Closed

Testpr pwa3248 #4243

wants to merge 4 commits into from

Conversation

glo42707
Copy link
Contributor

@glo42707 glo42707 commented Mar 20, 2024 •
edited
Loading

TODO: Testing the PR deploy test

Closes # https://jira.corp.adobe.com/browse/PWA-3248

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo42707 glo42707 added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 20, 2024
@glo42707 glo42707 self-assigned this Mar 20, 2024
@glo42707 glo42707 added accessibility Accessibility improvements based on WCAG 2.0 standards. Progress: ready for review and removed Progress: review labels Mar 20, 2024
@glo42707 glo42707 added dependencies Pull requests that update a dependency file Progress: ready for review and removed Progress: review labels Mar 20, 2024
@glo42707 glo42707 requested a review from glo82145 March 20, 2024 11:13
@glo42707 glo42707 added the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Mar 20, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 20, 2024 •
edited
Loading

Fails
🚫 Missing "Description" section. Please add it back, with detail.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3248.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 11b2c98

@glo42707
Copy link
Contributor Author

Closing PR since it was just for testing

@glo42707 glo42707 closed this Mar 20, 2024
@glo42707 glo42707 deleted the testpr-pwa3248 branch March 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo82145 glo82145 Awaiting requested review from glo82145

Assignees

@glo42707 glo42707

Labels
accessibility Accessibility improvements based on WCAG 2.0 standards. dependencies Pull requests that update a dependency file needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glo42707 @pwa-studio-bot @glo80771