-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/pwa 3377 after login issue on order success page #4354
Open
del15881
wants to merge
5
commits into
develop
Choose a base branch
from
bugfix/PWA-3377-after-login-issue-on-order-success-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix/pwa 3377 after login issue on order success page #4354
del15881
wants to merge
5
commits into
develop
from
bugfix/PWA-3377-after-login-issue-on-order-success-page
+240
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionality to be able to set and get the new flag value
del15881
added
enhancement
New feature or request
version: Minor
This changeset includes functionality added in a backwards compatible manner.
labels
Nov 19, 2024
|
glo82145
previously approved these changes
Nov 22, 2024
run scaffold-pwa |
Successfully started codebuild job for |
glo82145
reviewed
Nov 27, 2024
// Return an empty response if no valid order or shipping address exists | ||
return; | ||
|
||
//Below code can be uncommented in case of wanting to show the order success page with blank shipping address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
pkg:peregrine
pkg:venia-ui
Progress: review
version: Minor
This changeset includes functionality added in a backwards compatible manner.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr Adds the functionality to redirect a guest user to the account-information page when they register an account from the order-confirmation/order-success page.
On login from the order-confirmation/order-success page guest users will be redirected to /order-history page.
Related Issue
https://jira.corp.adobe.com/browse/PWA-3377
Closes #PWA-3377 (https://jira.corp.adobe.com/browse/PWA-3377)
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist