feat: add option to hide other Klipper & Moonraker instances #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
dosubot
bot
added
the
size:L
|
Language file analysis report:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @meteyou - I've reviewed your changes - here's some feedback:
Overall Comments:
- Great work on modularizing the code and adding the new feature. Consider profiling the changes to ensure there's no significant performance impact, especially with the added conditional logic.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -0,0 +1,154 @@ | |||
| <template> | |||
There was a problem hiding this comment.
suggestion: Add component description and usage comments
This new component improves modularity, but it would be helpful to add comments at the top of the file explaining its purpose and how it interacts with the parent component. This will make it easier for other developers to understand and use this component correctly.
<!-- TopCornerMenuService.vue -->
<!-- This component provides a configurable top corner menu dialog. -->
<!-- It is used to display alerts or confirmations in a modal format. -->
<!-- Props: show (Boolean), title (String), isMobile (Boolean) -->
<template>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to hide all other Klipper & Moonraker instances in the top right corner menu. This will be useful for multi instances. This PR will also hide the stop service button from the current Moonraker instance and fix the confirm dialog for other Klipper instances.
Related Tickets & Documents
fixes #2027
Mobile & Desktop Screenshots/Recordings
before:
after:
[optional] Are there any post-deployment tasks we need to perform?
none
Summary by Sourcery
Introduce a feature to hide other Klipper and Moonraker instances in the top corner menu, enhancing multi-instance management. Refactor the service management in the menu to use a new component, and fix the confirmation dialog for Klipper instances.
New Features:
Bug Fixes:
Enhancements: