Use boolean type for Directional light cast-shadows property (inter…

…nal-1831)
mapbox · Sep 12, 2024 · 00dd47d · 00dd47d
1 parent 5affccd
commit 00dd47d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/style-spec/reference/v8.json b/src/style-spec/reference/v8.json
@@ -483,9 +483,6 @@
       "default": false,
       "doc": "Enable/Disable shadow casting for this light",
       "transition": false,
-      "expression": {
-        "interpolated": false
-      },
       "property-type": "data-constant",
       "sdk-support": {
         "basic functionality": {

diff --git a/src/style-spec/types.ts b/src/style-spec/types.ts
@@ -347,7 +347,7 @@ export type DirectionalLightSpecification = {
         "color-transition"?: TransitionSpecification,
         "intensity"?: PropertyValueSpecification<number>,
         "intensity-transition"?: TransitionSpecification,
-        "cast-shadows"?: ExpressionSpecification,
+        "cast-shadows"?: boolean,
         "shadow-intensity"?: PropertyValueSpecification<number>,
         "shadow-intensity-transition"?: TransitionSpecification
     },

diff --git a/test/build/typings/index.ts b/test/build/typings/index.ts
@@ -394,6 +394,20 @@ map.setTerrain({'source': 'mapbox-dem', 'exaggeration': 1.5});
 map.setTerrain(undefined);
 map.setTerrain(null);
 
+//
+// 3D Lights
+//
+
+map.setLights([
+    {
+        "id": "directional",
+        "type": "directional",
+        "properties": {
+            "cast-shadows": true,
+        }
+    }
+]);
+
 //
 // Query features
 //