Use Mozilla certificates in urlopen() #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This suggestion arises from using PubChemPy in an application that has binaries built with pyinstaller. When this is done in a GitHub action, for some reason on MacOS there are failures at runtime associated with self-certified certificates; detail at molpro/iMolpro#140. I have not got to the bottom of why, but the problem is solved by explicitly using the Mozilla collection of root certificates in the call to |
|
Perhaps this addresses #89 ? |
|
Although it hasn't been officially merged, it effectively resolved my issue from #89 , thanks. |
|
@mcs07 please could you consider merging this widely-needed fix so that none of us have to continue holding privately-modified copies? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.