Revert node replacement behavior so that the framework does not pass … #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Dcassandra.replace_address if a task fails and restarts Summary: Reverts https://github.com/mesosphere/dcos-cassandra-service/pull/362/files. Reviewers: zhiyan, varung, zjay Subscribers: #cassandraservice Differential Revision: https://code.uberinternal.com/D742838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-Dcassandra.replace_address if a task fails and restarts.
Summary: Reverts #362.
After testing with some deployments, we have found out that this causes problems when multiple Cassandra tasks fail at the same time. A node cannot bootstrap if any node is in the DN state, so we need to remove the node using
nodetool removenode <hostid>. But then this change passes -D replace_address every time it starts the task but we have already removed the node and Cassandra crash loops.