Sandbox Plugin Implementation and Testing #468
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented the int sandbox_{category}(void *ctx, bool allow) functions and wrote a test for each one for the following categories of system calls:
IO - Sockets - IPC - Process - Filesystems - Time - Memory - Signals
Feature #465
Type of change
Checklist:
make test
orctest -VV -R <test-name>
)../docker-compose.sh test &> output
and attached the output.OPTION_BUILD_ADDRESS_SANITIZER
or./docker-compose.sh test-address-sanitizer &> output
andOPTION_TEST_MEMORYCHECK
.OPTION_BUILD_THREAD_SANITIZER
or./docker-compose.sh test-thread-sanitizer &> output
.Helgrind
in case my code works with threading.make clang-format
in order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.