-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Digest Export and Manifest Creation for Multi-Arch Docker Builds #521
Draft
Bcoderx6
wants to merge
20
commits into
metacall:develop
Choose a base branch
from
Bcoderx6:feature/multi-arch-docker-build-with-digests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Digest Export and Manifest Creation for Multi-Arch Docker Builds #521
Bcoderx6
wants to merge
20
commits into
metacall:develop
from
Bcoderx6:feature/multi-arch-docker-build-with-digests
+64
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances our GitHub Actions workflow to support multi-architecture Docker builds with proper digest handling. Key changes include: - Build and push Docker images for amd64, arm64, arm/v6, and arm/v7 architectures - Implement digest collection and artifact uploading for each architecture - Create a manifest list combining all architecture-specific images - Add conditional execution to skip pushes on pull requests - Improve error handling and add Docker logout steps for security These updates enable us to efficiently build and distribute our Docker images across multiple architectures, improving compatibility and streamlining our deployment process. Users can now pull the appropriate image for their system architecture automatically.
I converted it into draft because as there is no test related to it, we will need to review this in order to check if it works properly. Meanwhile the PR has no tests or it has not been tested by us, it will remain as a draft. |
I assume this can be closed in favor of #535, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Docker image build workflow to support exporting image digests and creating a manifest list for multi-architecture Docker builds. The changes include:
build
job now exports digests for each platform and uploads them as artifacts.merge
job downloads all digests and creates a manifest list with these digests for each platform.The
login
andlogout
steps for DockerHub are currently commented out. Uncomment these steps if DockerHub authentication is required. The workflow now supportslinux/amd64
,linux/arm64
,linux/arm/v6
, andlinux/arm/v7
platforms.