Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

application/x-yaml -> application/yaml #10613

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from
Open

application/x-yaml -> application/yaml #10613

wants to merge 1 commit into from

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Mar 16, 2024

sdelamo
sdelamo requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change. Don't remove it. add a new type for application/yaml instead

@graemerocher graemerocher mentioned this pull request Mar 27, 2024
Open
@altro3 altro3 changed the base branch from 4.4.x to 5.0.x April 7, 2024 16:08
@altro3 altro3 requested a review from sdelamo April 7, 2024 16:08
sdelamo
sdelamo requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, document the breaking change in the documentation.

@sdelamo sdelamo added the type: breaking Introduces a breaking change label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo requested changes

Assignees
No one assigned
Labels
type: breaking Introduces a breaking change
Projects
5.0.0 Release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altro3 @sdelamo