Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creatingClient.adoc #11359

Open
wants to merge 1 commit into
base: 4.7.x
Choose a base branch
from

Conversation

TbirdDuncan
Copy link

documentation is sparse on adding the http-client implementation and the hello world cli command creates an app with the dependency only on compile/testImplementation creating issues with requestInterceptors

documentation is sparse on adding the http-client implementation and the hello world cli command creates an app with the dependency only on compile/testImplementation creating issues with requestInterceptors
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this change. You are highlighting the Netty based implementation of the http client but users may want to use the JDK based implementation. The paragraph above links to the http client implementation where users can find the necessary dependencies.

@TbirdDuncan
Copy link
Author

TbirdDuncan commented Nov 22, 2024

I think thats fair, however I implore folks to try to get a new user to build a micronaut client/server. It is quite the hassle with things are configured atm. I'm open to exploring new ideas. IMO the best solution is to better the error messaging that arises due when you try to inject the client around your app. Which is mentioned in the op (requestInterceptors). There's not enough guidance, if that makes sense. However, it still in no way states that it's required to have these on your implementation path to proceed.

@glorrian
Copy link
Contributor

dependency that you mentioned has strong binding to the netty based impl of the client, so i think the documentation should explain all case of the MK usage and you'd better be able to tell users how to choose between a client implementation for real impact of this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants