Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LocalDate and LocalDateTime converters #11381

Closed
wants to merge 2 commits into from
Closed

Remove LocalDate and LocalDateTime converters #11381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c738b
Fix LocalDate and LocalDateTime conversion to Date
radovanradic Nov 24, 2024
7125cae
Remove LocalDate and LocalDateTime converters
radovanradic Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions context/src/main/java/io/micronaut/runtime/converters/time/TimeConverterRegistrar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,6 @@ public void register(MutableConversionService conversionService) {
addTemporalToDateConverter(conversionService, Instant.class, Function.identity());
addTemporalToDateConverter(conversionService, OffsetDateTime.class, OffsetDateTime::toInstant);
addTemporalToDateConverter(conversionService, ZonedDateTime.class, ZonedDateTime::toInstant);
// these two are a bit icky, but required for yaml parsing compatibility
// TODO Micronaut 4 Consider deletion
addTemporalToDateConverter(conversionService, LocalDate.class, ld -> ld.atTime(0, 0).toInstant(ZoneOffset.UTC));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is converting LocaleDate to Date using UTC and micronaut-data is using default timezone when converting back so we are getting date diff issues. I believe this should use default timezone as well.
There is also comment about removal of this conversion in Micronaut4. Can it be removed? If yes, then we can add converter needed in micronaut-data using default timezone and the issue would be fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yawkat Can we remove these conversions above, or change it to not use UTC but default timezone? It is causing issue in micronat-data explained in the description of this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree that this should be default TZ. Yes they should be removed, but using system TZ is worse.

Why does data need to convert these at all? java.sql.Date has actual well-defined conversions from and to LocalDate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

micronaut-data registers various conversions for dates and is always using timezones.
With this converter defined in micronaut-core, even if we register this in micronaut-data

conversionService.addConverter(java.sql.Date.class, LocalDate.class, date -> date.toLocalDate());

we will get wrong date when converted back.

I removed these converters from micronaut-core, hopefully nothing will break.

addTemporalToDateConverter(conversionService, LocalDateTime.class, ldt -> ldt.toInstant(ZoneOffset.UTC));
}

private <T extends TemporalAccessor> void addTemporalStringConverters(MutableConversionService conversionService, Class<T> temporalType, DateTimeFormatter isoFormatter, TemporalQuery<T> query) {
Expand Down
Loading