Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Document Connector] SignUp E-Document Connector #27261

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

geschwint
Copy link

@geschwint geschwint commented Sep 16, 2024

E-Documents connector interface implementation between Business Central and SignUp Web API for electronic invoices

Work Item(s)
Fixes #27054
Fixes AB#541805

@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Sep 16, 2024
@geschwint
Copy link
Author

@aholstrup1 This pull request has replaced #27084 due to using merge instead of rebase policy locally. Thank you for your patience

@geschwint geschwint marked this pull request as ready for review September 16, 2024 08:16
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 16, 2024
@geschwint
Copy link
Author

geschwint commented Sep 24, 2024

Comment on last commit. Resolving object name conflict in module. Can't have two objects with the same name in the same module even if they are in different namespaces. Ref: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-namespaces-overview

Error in build: https://github.com/microsoft/ALAppExtensions/actions/runs/10956384133/job/30482980067?pr=27261

@Groenbech96
Copy link
Contributor

Comment on last commit. Resolving object name conflict in module. Can't have two objects with the same name in the same module even if they are in different namespaces. Ref: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-namespaces-overview

Error in build: https://github.com/microsoft/ALAppExtensions/actions/runs/10956384133/job/30482980067?pr=27261

Yep i was looking at this issue as well yesterday. Can you find me and ping me on the E-Doc Open Source teams channel?

@geschwint
Copy link
Author

Couple of comments and some questions for me to understand the code better. Do you have API doc reference you can link me?

Here is the link to the API: https://edoc.exflowdev.cloud/swagger/index.html


procedure GetRootBearerAuthText(): SecretText;
begin
exit(secretStrSubstNo(BearerTxt, GetRootAuthBearerToken()));
Copy link
Contributor

@Groenbech96 Groenbech96 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exit(secretStrSubstNo(BearerTxt, GetRootAuthBearerToken()));
exit(SecretStrSubstNo(BearerTxt, GetRootAuthBearerToken()));

@Groenbech96
Copy link
Contributor

@geschwint Can you add the test application to the PR as well?

@Groenbech96
Copy link
Contributor

@geschwint build will fail now because of obsoleted interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Enable connector with SignUp for E-Documents
3 participants