-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shopify] Log Skipped Records on export processes #27539
[Shopify] Log Skipped Records on export processes #27539
Conversation
Apps/W1/Shopify/app/src/Logs/Tables/ShpfySkippedRecord.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyExport.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyExport.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Logs/Codeunits/ShpfySkipRecordMgt.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyExport.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/test/Logs/ShpfySkippedRecordLogTest.Codeunit.al
Outdated
Show resolved
Hide resolved
@tinestaric, could you pull main? CI is failing on an unrelated issue, we've fixed in the main branch. |
The PR was successfully merged internally 🥳 This PR has a compilation issues which must get addressed before we can merge: |
@JesperSchulz fixed the codeunit name :) |
Build still failing. Looks strange... The code is in, so it doesn't really matter. I would love to merge this PR though, rather than just close it. But it's also not worth spending time on. Your call :-) |
This reverts commit c8b01d7.
This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko
Fixes #26819
Created new structure to log records skipped on export
Solution has new structure possible to open by typing "Shopify Skipped Records". On page user can see all the skipped records with reasons and date and time when the record was skipped. User can also open the related record using "Show record" action or clicking the "Description" field value.
Log cases:
Customer:
Posted Sales Invoice:
Product:
Shipments:
If the condition met log record is being created.
Retention policy
Retention policy is inserted on extension install. It can be turned on "Retention Policies" page.
Fixes AB#473306