Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shopify] Log Skipped Records on export processes #27539

Merged
merged 34 commits into from
Oct 30, 2024

Conversation

tinestaric
Copy link
Contributor

@tinestaric tinestaric commented Oct 25, 2024

This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko
Fixes #26819

Created new structure to log records skipped on export

Solution has new structure possible to open by typing "Shopify Skipped Records". On page user can see all the skipped records with reasons and date and time when the record was skipped. User can also open the related record using "Show record" action or clicking the "Description" field value.

Log cases:

Customer:

  • Customer has empty email
  • Customer with same email or phone exists

Posted Sales Invoice:

  • Customer does not exist in Shopify
  • Payment terms do not exist in Shopify
  • Customer No. is Default Customer No. for Shopify Shop
  • Customer No. is used in Shopify Customer Template
  • No lines existing in sales invoice
  • Invalid Quantity
  • Empty No. value

Product:

  • Item is blocked/sales blocked (Item Variant)
  • Item is blocked

Shipments:

  • Related Shopify Order does not exist
  • No lines in Posted Sales Shipment applicable for fulfillment
  • No corresponding fulfillment found in Shopify.

If the condition met log record is being created.

Retention policy

Retention policy is inserted on extension install. It can be turned on "Retention Policies" page.

Fixes AB#473306

@tinestaric tinestaric requested a review from a team as a code owner October 25, 2024 08:49
onbuyuka
onbuyuka previously approved these changes Oct 28, 2024
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Oct 29, 2024
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Oct 29, 2024
@JesperSchulz JesperSchulz self-assigned this Oct 29, 2024
JesperSchulz
JesperSchulz previously approved these changes Oct 30, 2024
@JesperSchulz
Copy link
Contributor

@tinestaric, could you pull main? CI is failing on an unrelated issue, we've fixed in the main branch.

@JesperSchulz
Copy link
Contributor

The PR was successfully merged internally 🥳 This PR has a compilation issues which must get addressed before we can merge:
AA0215 The file ShpfySkipRecordMgt.Codeunit.al has an incorrect name. The valid name is ShpfySkippedRecord.Codeunit.al.

@petemchlk petemchlk dismissed stale reviews from onbuyuka and JesperSchulz via cfa6b3b October 30, 2024 14:13
@petemchlk
Copy link
Contributor

@JesperSchulz fixed the codeunit name :)

@JesperSchulz
Copy link
Contributor

Build still failing. Looks strange... The code is in, so it doesn't really matter. I would love to merge this PR though, rather than just close it. But it's also not worth spending time on. Your call :-)

@mazhelez mazhelez merged commit c8b01d7 into microsoft:main Oct 30, 2024
6 of 8 checks passed
aholstrup1 added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] Shopify Contributions
7 participants