[E-Document Connector] Logiq E-Document Connector #27562
Conversation
tstefanovicius
requested review from
Groenbech96,
WaelAbuSeada and
aholstrup1
as code owners
|
@microsoft-github-policy-service agree company="Companial" |
tstefanovicius
changed the title
|
New pull request instead of #27101 |
|
Thanks for fixing the issue.
Feel free to look at Avalara as the example. In the mean time we will start looking at the code. |
|
|
||
| enum 6380 "Logiq API Engine" | ||
| { | ||
| Extensible = false; |
| @@ -0,0 +1,19 @@ | |||
| namespace Microsoft.EServices.EDocumentConnector.Logiq; | |||
|
|
|||
| enum 6380 "Logiq API Engine" | |||
| @@ -0,0 +1,182 @@ | |||
| namespace Microsoft.EServices.EDocumentConnector.Logiq; | |||
|
|
|||
| codeunit 6380 "Logiq Auth" | |||
There was a problem hiding this comment.
Please move the code to EDocumentConnectors
Create app for the connector.
Create app for the test automation.
Feel free to look at Avalara as the example.
In the mean time we will start looking at the code.
There was a problem hiding this comment.
Created connector and test apps. Moved to EDocumentConnectors folder
| ResponseMessage: HttpResponseMessage; | ||
| AccessToken, RefreshToken : SecretText; | ||
| AccessTokExpires, RefreshTokExpires : DateTime; | ||
| AuthenticationFailedErr: Label 'Logiq authentication failed. Please check the user credentials.'; |
There was a problem hiding this comment.
Labels needs to be on global var.
There was a problem hiding this comment.
Labels moved to global var
|
|
||
| internal procedure CheckUserCredentials(var LogiqConnectionUserSetup: Record "Logiq Connection User Setup") | ||
| var | ||
| NoSetupErr: Label 'No user setup found. Please fill the user setup in the Logiq Connection User Setup page.'; |
There was a problem hiding this comment.
Labels moved to global var
|
|
||
| page 6380 "Logiq Connection Setup" | ||
| { | ||
| Caption = 'E-Document External Connection Setup'; |
There was a problem hiding this comment.
Different name. Use connector name
| DataClassification = CustomerContent; | ||
| fields | ||
| { | ||
| field(1; PK; Code[10]) |
Added tests Added app.json files Fixes
|
@tstefanovicius new interfaces will break the build :) |
|
Ahh, it was committed two days ago, will update |
Set Setup tables to Internal
| @@ -0,0 +1,20 @@ | |||
| namespace Microsoft.EServices.EDocumentConnector.Logiq; | |||
There was a problem hiding this comment.
All files should contain the license comments as the first thing.
| { | ||
| addafter(GetApproval) | ||
| { | ||
| action(UpdateStatus) |
There was a problem hiding this comment.
Great that we have an action. 👍 🥇
Set visibility based on if document relates to Service, and is incomming/Outgoing?
Can you change this to use the IDocumentAction interface. Then you dont have to do the manual logging you are doing. You should not do that essentially. Framework shoud.
I can see that this also checks approval. What is stauses is it checking. Do we have a more specific name?
There was a problem hiding this comment.
If this is for sent documents. Can we use Approval action that already exissts?
There was a problem hiding this comment.
Sent documents in Logiq system can have statuses: "received" and "processed" (which we translate to "In Progress Logiq" service status), "distributed" (translate to approved to work with the framework even thought it's not exactly the same status) and "failed" (translate to "Failed Logiq"). We could use standard approval action but if I understand correctly, the standard status logging would not recognize custom service statuses as processed or error, so the document status would always be in progress.
Added logo Updated app.jsons Added Logiq External Id field
E-Documents connector interface implementation between Business Central and Logiq
Work Item(s)
Fixes #27058
Fixes AB#541809