-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): Update V9 Charts to use DataVizGradientPalette #33323
base: master
Are you sure you want to change the base?
Conversation
change/@fluentui-react-charts-preview-d9ff82b5-6274-429e-8f9d-bd400e647d4b.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
📊 Bundle size report✅ No changes found |
PR CI is failing. |
Pull request demo site: URL |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
packages/charts/react-charts-preview/library/src/components/DonutChart/DonutChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
...charts/react-charts-preview/library/src/components/HorizontalBarChart/HorizontalBarChart.tsx
Outdated
Show resolved
Hide resolved
CI error should be fixed with this commit 0cc5413 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
apps/vr-tests-react-components/src/stories/Charts/DonutChart.stories.tsx
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
*/ | ||
color: string; | ||
gradient: [string, string]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the term gradient is confusing. Lets use color only with this structure -> string | [string, string]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant in all places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh, ok, so it should work with either a single color string or gradient tuple. Will make the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct.
…types and stories
Implement DataVizGradientPalette and rounded corners in v9 charts as default
Modified
New Behavior (UI)
DonutChart
With Custom Gradient
HorizontalBarChart
With Custom Gradient
Notable Changes:
utilities/gradients.ts
color
properties to support gradients intypes/DataPoint.ts
New Usage
TODO
Related
#32008