chore(react-tag-picker): ensure no toggle behaviour when re-selecting already selected data #33344
+25
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
At the moment whenever the user tries to re-select the same option, the option is unselected. This happens because we're using
Combobox
logic internally to implementTagPicker
logic, but this is a bit problematic in this scenario asCombobox
supports toggling the selected data on the "option select event", meanwhileTagPicker
only allows selection on the "option select event", to unselect a tag should be clicked manually, it does not involve the combobox logicNew Behavior
onOptionsSelect
should be invoked with the currentselectedOptions
with no modificationsRelated Issue(s)