-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion): add extended support for reduced motion #33353
Open
layershifter
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
layershifter:fix/create-motion-reduced
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(motion): add extended support for reduced motion #33353
layershifter
wants to merge
1
commit into
microsoft:master
from
layershifter:fix/create-motion-reduced
+316
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
fabricteam
reviewed
Nov 27, 2024
@@ -6,5 +6,6 @@ import * as React from 'react'; | |||
export type MotionBehaviourType = 'skip' | 'default'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Avatar Converged.badgeMask.chromium.png | 38 | Changed |
Avatar Converged.Badge Mask RTL.chromium.png | 20 | Changed |
Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Drawer.overlay drawer full.chromium.png | 7 | Changed |
layershifter
force-pushed
the
fix/create-motion-reduced
branch
3 times, most recently
from
November 27, 2024 16:52
2f16fd0
to
07ad3b3
Compare
layershifter
changed the title
fix(motion): handle reduced motion in createMotionComponent()
feat(motion): add extended support for reduced motion
Nov 27, 2024
layershifter
force-pushed
the
fix/create-motion-reduced
branch
from
November 27, 2024 16:54
07ad3b3
to
7649e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No way to customize motions' behavior when reduced motion is enabled.
New Behavior
reducedMotion
option toAtomMotion
type.By default, when reduced motion is enabled the duration of the animation is set to
1ms
.reducedMotion
allows to customize a reduced motion version of the animation: