Add GenerateDSAParameters and SupportsDSA functions #1421
+93
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertakman
requested review from
microsoft-golang-review-bot and
a team
as code owners
mertakman
force-pushed
the
dev/mert/dsa
branch
from
a7df47e
to
dfcf6a2
Compare
mertakman
changed the title
qmuntal
approved these changes
Nov 27, 2024
dagood
reviewed
Nov 27, 2024
| @@ -854,6 +886,14 @@ index 00000000000000..08600a2c833ac7 | |||
| +func VerifyEd25519(pub *PublicKeyEd25519, message, sig []byte) error { | |||
| + panic("cryptobackend: not available") | |||
| +} | |||
| + | |||
| +func SupportsDSA(l, n int) bool { | |||
| + return false | |||
There was a problem hiding this comment.
Why return false rather than panic("cryptobackend: not available")? (This is the only return in the file.)
| @@ -259,3 +259,11 @@ index 00000000000000..7c5fbeea717618 | |||
| +func VerifyEd25519(pub *PublicKeyEd25519, message, sig []byte) error { | |||
| + panic("cryptobackend: not available") | |||
| +} | |||
| + | |||
| +func SupportsDSA(l, n int) bool { | |||
| + return false | |||
There was a problem hiding this comment.
(On the other hand, this particular return does make sense, because it's tied to a backend that might work.)
| @@ -467,6 +467,18 @@ index 00000000000000..3d3d13709de5ac | |||
| +func VerifyEd25519(pub *PublicKeyEd25519, message, sig []byte) error { | |||
| + panic("cryptobackend: not available") | |||
| +} | |||
| + | |||
| +func SupportsDSA(l, n int) bool { | |||
| + return n != 224 | |||
There was a problem hiding this comment.
It seems unusual to me to support all sizes except for one... add a comment? Or add a cng.SupportsDSA function to the CNG backend repo and call that to let it decide and document this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.