chore: ignore GitHub Codespaces BROWSER env var #3068
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
codespaces-ignore-env
branch
from
8995b08
to
607f680
Compare
dgozman
reviewed
Nov 26, 2024
| @@ -40,7 +40,8 @@ public static string BrowserName | |||
| get | |||
| { | |||
| var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant(); | |||
| if (!string.IsNullOrEmpty(browserFromEnv)) | |||
| // GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus. | |||
| if (!string.IsNullOrEmpty(browserFromEnv) && !browserFromEnv!.StartsWith("/vscode/")) | |||
There was a problem hiding this comment.
Ouch! I don't like hardcoding this.
Perhaps we should change the error below into a warning and run chromium, if we consider BROWSER to be a legacy thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
/vscode/bin/linux-x64/f1a4fb101478ce6ec82fe9627c43efbf9e98c813/bin/helpers/browser.shwhich prevents customers from running the getting started on GitHub Codespaces.We respect the
BROWSERenv var for legacy reasons.Fixes #2847