-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UWP .NET 9 support for MSTest extensions #3848
Open
Sergio0694
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
Sergio0694:user/sergiopedri/uwp-net9-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add UWP .NET 9 support for MSTest extensions #3848
Sergio0694
wants to merge
6
commits into
microsoft:main
from
Sergio0694:user/sergiopedri/uwp-net9-support
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-support
branch
from
October 19, 2024 19:32
2ad0079
to
431954a
Compare
Youssef1313
reviewed
Nov 9, 2024
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-support
branch
from
November 25, 2024 07:37
d50771e
to
29abbe2
Compare
Youssef1313
reviewed
Nov 25, 2024
@@ -70,6 +70,10 @@ | |||
<file src="net8.0\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll" target="build\net8.0\" /> | |||
<file src="net8.0\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.xml" target="build\net8.0\" /> | |||
|
|||
<!-- net9.0 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<!-- net9.0 --> | |
<!-- net9.0-windows10.0.17763.0 --> |
@Sergio0694 Looks like there is a packaging failure.
|
It's ok we will sync with @Sergio0694 offline this week to answer a couple of high level questions before we resume work here. Thanks @Youssef1313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the initial work to support UWP apps using .NET 9 (see here).
This tackles the extensions assembly:
net8.0-10.0.26100.0
(we can bump to .NET 9 once it goes GA)WINDOWS_UWP
on this targetnet8.0-windows10.0.26100.0/uwp
UseUwpTools
is set (ie. this is a UWP app using .NET 9)