Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP .NET 9 support for MSTest extensions #3848

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Sergio0694
Copy link
Member

This PR includes the initial work to support UWP apps using .NET 9 (see here).
This tackles the extensions assembly:

  • Multi-target net8.0-10.0.26100.0 (we can bump to .NET 9 once it goes GA)
  • Define WINDOWS_UWP on this target
  • Pack this .dll into net8.0-windows10.0.26100.0/uwp
  • Update .targets to reference it if UseUwpTools is set (ie. this is a UWP app using .NET 9)

@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/uwp-net9-support branch from 2ad0079 to 431954a Compare October 19, 2024 19:32
Directory.Build.props Outdated Show resolved Hide resolved
@@ -70,6 +70,10 @@
<file src="net8.0\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll" target="build\net8.0\" />
<file src="net8.0\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.xml" target="build\net8.0\" />

<!-- net9.0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- net9.0 -->
<!-- net9.0-windows10.0.17763.0 -->

@Youssef1313
Copy link
Member

@Sergio0694 Looks like there is a packaging failure.

D:\a\_work\1\s\.dotnet\sdk\9.0.100\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5050: Attempted to pack multiple files into the same location(s). The following destinations were used multiple times: contentFiles\any\any\Extensions\WinUI\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.xml [D:\a\_work\1\s\src\Package\MSTest.Internal.TestFx.Documentation\MSTest.Internal.TestFx.Documentation.csproj]
##[error].dotnet\sdk\9.0.100\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5050: (NETCORE_ENGINEERING_TELEMETRY=Build) Attempted to pack multiple files into the same location(s). The following destinations were used multiple times: contentFiles\any\any\Extensions\WinUI\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.xml

@Evangelink
Copy link
Member

It's ok we will sync with @Sergio0694 offline this week to answer a couple of high level questions before we resume work here.

Thanks @Youssef1313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants