Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark IgnoreAttribute as not inherited #4183

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Youssef1313
Copy link
Member

It makes better sense to reflect the real semantics of the attribute.

@Evangelink Any backcompat concerns with this change?

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe.

@Evangelink Evangelink merged commit 8605b32 into microsoft:main Nov 27, 2024
9 checks passed
@Youssef1313 Youssef1313 deleted the ignore-not-inherited branch November 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants