Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deleted documents are highlighted #2467

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bk201-
Copy link
Contributor

@bk201- bk201- commented Nov 25, 2024

Fixes #2437

  • Deleted documents highlighted by line-through decoration
  • No actions with deleted rows

image
image
image
image

- Deleted documents highlighted by line-through decoration
- No actions with deleted rows
- Deleted documents highlighted by line-through decoration
- No actions with deleted rows
@bk201- bk201- requested review from a team as code owners November 25, 2024 10:04
@tnaum-ms
Copy link
Collaborator

It’s an interesting approach! However, I anticipate that once it’s available, there will be feature requests for an ‘undo’ operation.

@bk201-
Copy link
Contributor Author

bk201- commented Nov 25, 2024

Well, then we will say that result is just Query Representation what we can't change as well as undo any actions.

Why can't we remove these records from the table? Because the have statistics and metrics which linked to certain results in the table. My opinion, it is obvious that any actions with records will be represented only after re-running query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants