Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use [email protected] on DevContainer #10642

Merged

Conversation

Nanashia
Copy link
Contributor

What

VS CodeのDevContainerのNodeのバージョンを18.16.0にする。

Why

#10639 でNodeの要求バージョンが18.16.0に上がったため、DevContainerのデフォルトのNodeであるv18.14.2では pnpm start したとき弾かれるようになった。
これを解決するためdevcontainer.jsonで明示的に 18.16.0 を使うようにする

Additional info (optional)

  • DevContainerをRebuildしてnodeのバージョンが上がっていること。
  • pnpm startしてdevサーバーが立ち上がること

Before

node ➜ /workspace (chore/update-node-on-devcontainer) $ node -v
v18.14.2

After

node ➜ /workspace (chore/update-node-on-devcontainer) $ node -v
v18.16.0

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #10642 (1cd2265) into develop (98383b2) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #10642      +/-   ##
===========================================
- Coverage    76.10%   76.06%   -0.05%     
===========================================
  Files          898      897       -1     
  Lines        88660    88517     -143     
  Branches      6249     6247       -2     
===========================================
- Hits         67479    67327     -152     
- Misses       21181    21190       +9     

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina tamaina merged commit 973e70b into misskey-dev:develop Apr 15, 2023
@tamaina
Copy link
Contributor

tamaina commented Apr 15, 2023

👍

na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants