Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a
Delay
is a relatively heavy operation which involves creating two mutexes and anArc
, so it makes sense to avoid callingDelay::new
repeatedly. In this change I introduced a new boolean field which tracks ifclock
is actually used, and instead of creating a newDelay
from scratch I callDelay::reset
on existing one if possible. This should help with performance in scenarios when buffered items are more often yielded by timeout rather than hitting maximum capacity.(BTW I do not understand why
clock
is pinned sinceDelay
isUnpin
anyway. Is it an oversight?)