-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable option to skip base64 encoding of headers with pure ASCII characters #71
Open
samwan-loops
wants to merge
15
commits into
muratgozel:master
Choose a base branch
from
Loops-so:option-to-skip-encoding-pure-ascii-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable option to skip base64 encoding of headers with pure ASCII characters #71
samwan-loops
wants to merge
15
commits into
muratgozel:master
from
Loops-so:option-to-skip-encoding-pure-ascii-headers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with pure ASCII values. Update unit tests to encode or skip encoding headers with pure ASCII values, and to encode values with non-ASCII characters.
…ader. Add unit test support for Reply-To header.
… entrypoints for createMimeMessage.
…ne grain control over header encoding conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Spam detection servers such as rspamd consider certain Base64-encoded headers to be red flags, and increases the spam score of emails with such headers. By default, MIMEText will applies base64 encoding to all headers, which means that emails encoded with the MIMEText library will have higher spam scores by default.
Proposal: Provide an optional flag in EnvironmentContext to skip base64 encoding for a header if it contains only ascii characters. Since this flag is optional, there is no breaking change.
Approach:
skipEncodingPureAsciiHeaders
flag toEnvironmentContext
to skip encoding headers with pure ASCII values.optionallySkipPureAsciiEncoding
to MIMEMessageHeader to detect whether a value is pure ASCII, and skip encoding it if the option is enabled.dumpMailboxMulti
ordumpMailboxSingle
, and for theSubject
header.MIMEMessageHeader.spec.js
unit test to cover encoding headers with non-ascii characters, and optionally encoding headers with ascii-only characters.Comment: There are some unit tests not passing, but they are not passing in the main branch and do not seem to be due to the changes in this PR.