New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added SCRAPYD_SERVER HTTPS support #230

Open

ritikkumarsahu wants to merge 1 commit into my8100:master from ritikkumarsahu:master

ritikkumarsahu commented Mar 22, 2024

Currently Scrapydweb doesn't support Scrapyd Server hosted remotely with HTTPS. I have Added the support for https.

SCRAPYD_SERVERS = [
('', '', 'https', example.com', '443', '')
]


          added SCRAPYD_SERVER HTTPS support

d7a0d8c

pep8speaks commented Mar 22, 2024

Hello @ritikkumarsahu! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file scrapydweb/utils/check_app_config.py:

Line 393:121: E501 line too long (121 > 120 characters)

In the file scrapydweb/utils/poll.py:

Line 183:121: E501 line too long (169 > 120 characters)

In the file scrapydweb/views/api.py:

Line 20:121: E501 line too long (127 > 120 characters)

In the file scrapydweb/views/files/log.py:

Line 56:121: E501 line too long (138 > 120 characters)
Line 69:121: E501 line too long (138 > 120 characters)

In the file scrapydweb/views/operations/deploy.py:

Line 287:121: E501 line too long (175 > 120 characters)

In the file scrapydweb/views/operations/schedule.py:

Line 368:121: E501 line too long (167 > 120 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet