Vf2 vs vf2pp #89
Open
Vf2 vs vf2pp #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
reviewed
Mar 7, 2023
| ``` | ||
|
|
||
| To do this same experiment on DiGraphs, we need to define an in-degree sequence and an out-degree sequence. | ||
| We will use the function *nx.directed_configuration_model(in_degree_sequence, out_degree_sequence, create_using, seed)*. Both degree sequences must have the same sum. Again this function returns a MultiDiGraph so we will have to convert it into a DiGraph. Let's do this in an example: |
There was a problem hiding this comment.
I'm surprised that the resulting degree sequences are the same for the two graphs. The multiedges are not likely to be the same -- and the selfloop edges are also likely to be a different number of edges with the two seeds. So when you convert to a non-multigraph, and remove the selfloops, you change the degree sequences. And it seems like you would be changing them in different ways. Have you checked that the two graphs have the same degree sequence? If they don't, the function will correctly return True, but it won't actually run any of the algorithm to find this out. I think it doesn't even create the data structures that would cost time for overhead in VF2++, but I'm not sure about that.
Co-authored-by: Dan Schult <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial draft of benchmarking of vf2 vs vf2++. There are still some details to fix in the plots (mainly x labels and some titles) and many TODOs.