Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search updates #1111

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Search updates #1111

merged 4 commits into from
Oct 23, 2024

Conversation

clarkmcadoo
Copy link
Contributor

@clarkmcadoo clarkmcadoo commented Oct 23, 2024

  • useScrollFreeze added to GlobalSearch
  • update old query params with new syntax

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for newrelic-gatbsy-theme-demo canceled.

Name Link
🔨 Latest commit 4781891
🔍 Latest deploy log https://app.netlify.com/sites/newrelic-gatbsy-theme-demo/deploys/67195d35986ac900086b3120

@clarkmcadoo clarkmcadoo changed the title fix: Remove the use of old search query params Search updates Oct 23, 2024
sunnyzanchi
sunnyzanchi previously approved these changes Oct 23, 2024
Copy link
Contributor

@sunnyzanchi sunnyzanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@@ -100,7 +100,7 @@ const SEO = ({ title, location, type, children }) => {
"@type": "SearchAction",
"target": {
"@type": "EntryPoint",
"urlTemplate": "${siteUrl}/?q={search_term_string}"
"urlTemplate": "${siteUrl}/search-results/?query=search_term_string&page=1}"search_term_string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a typo?

@clarkmcadoo clarkmcadoo merged commit 22ba558 into develop Oct 23, 2024
11 checks passed
@clarkmcadoo clarkmcadoo deleted the clark/search-fixes branch October 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants