remove remark-mdxjs, upgrade remark-mdx, clean up @mdx-js packages #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyzanchi
requested review from
a team,
clarkmcadoo and
LizBaker
and removed request for
a team
this package is v outdated and isn't actually required
`remark-mdx` switched to ESM in the latest version and can't be imported. Gatsby supports ESM gatsby-node with a `.mjs` extension and this works!
sunnyzanchi
force-pushed
the
sunny/remove-remark-mdxjs
branch
from
69edd8b
to
4f30134
Compare
✅ gatsby-theme-newrelic-develop deploy preview ready
|
using `babel-preset-gatsby` breaks the tests. `@babel/preset-react` is needed for JSX to work. not sure if `@babel/preset-env` is needed. adding the Gatsby mock to `jest-preprocess.mjs` was v important, basically no tests work without this
LizBaker
approved these changes
Sep 25, 2023
tabathadelane
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.