Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify tests pt3 #951

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Robustify tests pt3 #951

merged 3 commits into from
Oct 10, 2023

Conversation

tabathadelane
Copy link
Contributor

@tabathadelane tabathadelane commented Oct 9, 2023 •
edited
Loading

  • adds coverage for
    • AnnouncementBanner.js
    • GitHubIssueButton.js - mostly covered
    • HamburgerMenu.js
    • InlineCode.js
    • Logo.js
    • MDXLink.js
    • MarkdownContainer.js
    • Select.js
    • SelectInLine.js
    • Side.js
    • Table.js
  • delete AnimatedCard.js

@tabathadelane tabathadelane requested review from a team, clarkmcadoo and LizBaker and removed request for a team October 9, 2023 16:33
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 9, 2023 •
edited
Loading

✅ gatsby-theme-newrelic-develop deploy preview ready

@tabathadelane tabathadelane force-pushed the tabatha/robustify-tests-3 branch 2 times, most recently from 68f2629 to 31cbd00 Compare October 9, 2023 17:50
sunnyzanchi
sunnyzanchi approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sunnyzanchi sunnyzanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job, these are some great tests!

sunnyzanchi
sunnyzanchi reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sunnyzanchi sunnyzanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you have a commit with BREAKING CHANGE: in the footer before merging this, since we removed AnimatedCard

@tabathadelane tabathadelane merged commit 19275b1 into develop Oct 10, 2023
3 checks passed
@tabathadelane tabathadelane deleted the tabatha/robustify-tests-3 branch October 10, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyzanchi sunnyzanchi sunnyzanchi approved these changes

@clarkmcadoo clarkmcadoo clarkmcadoo approved these changes

@LizBaker LizBaker Awaiting requested review from LizBaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabathadelane @sunnyzanchi @clarkmcadoo