revert Gatsby 5 changes #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f30134.
This reverts commit 2287c1a.
This reverts commit f7be576.
This reverts commit e1b5d23.
This reverts commit a18084d.
This reverts commit 42ec26f.
This reverts commit d60aa36.
This reverts commit f445e49.
This reverts commit 80cc35a.
This reverts commit d11a777.
This reverts commit 60db122. fix: readd `gatsby-plugin-portal` as a dependency
This reverts commit d956fc2.
This reverts commit ebafc0d.
This reverts commit 1426d64.
This reverts commit 6528d29.
This reverts commit 0f42247.
This reverts commit 63bcfd7.
This reverts commit 4afc57b.
i couldn't figure out why this wasn't reverting how i expected it to, so i just copied the code from v7.1.3 and replaced it here
This reverts commit 175f473.
This reverts commit 2addd31.
This reverts commit 5789bf5.
This reverts commit 739e6cc.
This reverts commit 9bac64c.
This reverts commit 0cbdb30.
This reverts commit 049374d.
This reverts commit 0bc2c8d.
This reverts commit f1faa20.
This reverts commit 27ffb09.
This reverts commit e202af2.
sunnyzanchi
force-pushed
the
sunny/revert-gatsby5
branch
from
0539961
to
33e0296
Compare
BREAKING CHANGE: reverts the Gatsby 5 changes so the theme is back on Gatsby 4.
sunnyzanchi
force-pushed
the
sunny/revert-gatsby5
branch
from
33e0296
to
bedd2cf
Compare
sunnyzanchi
requested review from
a team,
clarkmcadoo and
LizBaker
and removed request for
a team
clarkmcadoo
reviewed
Dec 6, 2023
tabathadelane
approved these changes
Dec 6, 2023
clarkmcadoo
approved these changes
Dec 6, 2023
sunnyzanchi
added a commit
that referenced
this pull request
Dec 6, 2023
feat!: revert Gatsby 5 changes (#959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a lot of changed files, but primarily it just reverts a bunch of commits so that the codebase is back to its state @ 7.1.3, before we made any changes for Gatsby 5. there are some non-Gatsby 5 changes — like removing the AnimatedCard component — that i left in
testing
i'd recommend clearing
node_modulesfirst, thenyarning andyarn starting to test the site. the best way to review this PR is probably not to look at the commits or files changed, but to look at the diff between this branch and thev7.1.3tag. you can do this after checking out this branch withyarn diff v7.1.3. the changelog is huge, you can exclude it withgit diff v7.1.3 ':!*.md'things to look out for in the diff:
.mjspackage.json,demo/package.json, orpackages/gatsby-theme-newrelic/package.json