Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NR-322749 add test for process sample collection #1948

Merged
merged 1 commit into from
Nov 13, 2024
Merged

NR-322749 add test for process sample collection #1948

merged 1 commit into from
Nov 13, 2024

Conversation

rajrohanyadav
Copy link
Contributor

@rajrohanyadav rajrohanyadav commented Nov 6, 2024 •
edited
Loading

  • Add unit test for process sample func to ensure user CPU percent and system CPU percent is between 0 and 100.

@rajrohanyadav rajrohanyadav force-pushed the NR-322749-win-cpu-higher-than-100-percent branch 3 times, most recently from 927c23e to 9207751 Compare November 7, 2024 10:33
@rajrohanyadav rajrohanyadav marked this pull request as ready for review November 11, 2024 09:17
@rajrohanyadav rajrohanyadav requested a review from a team November 11, 2024 09:17
@rajrohanyadav rajrohanyadav force-pushed the NR-322749-win-cpu-higher-than-100-percent branch 2 times, most recently from 80f5246 to 3049ac1 Compare November 11, 2024 10:03
@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11815555852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.347%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 95.35%
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 11815313677: 0.03%
Covered Lines: 15365
Relevant Lines: 26793
💛 - Coveralls

alvarocabanas
alvarocabanas approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajrohanyadav rajrohanyadav requested a review from a team November 13, 2024 01:47
@davidgit davidgit removed the request for review from a team November 13, 2024 10:29
@rajrohanyadav rajrohanyadav force-pushed the NR-322749-win-cpu-higher-than-100-percent branch from 3049ac1 to 2f2e32c Compare November 13, 2024 10:39
@rajrohanyadav rajrohanyadav merged commit 7495234 into master Nov 13, 2024
24 of 25 checks passed
@rajrohanyadav rajrohanyadav deleted the NR-322749-win-cpu-higher-than-100-percent branch November 13, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocabanas alvarocabanas alvarocabanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajrohanyadav @coveralls @alvarocabanas