Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coveralls workflow step failures #1950

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rajrohanyadav
Copy link
Contributor

@rajrohanyadav rajrohanyadav commented Nov 7, 2024

coverage was broken as this steps was erroring out but we still continued with failure. e.g. https://github.com/newrelic/infrastructure-agent/actions/runs/11591051096/job/32274596731
This PR fixes this issue.

https://github.com/newrelic/infrastructure-agent/actions/runs/11721033733/job/32647827916

@rajrohanyadav rajrohanyadav requested a review from a team November 7, 2024 10:28
Copy link
Contributor

@DavSanchez DavSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Leaving some comments.

Copy link
Contributor

@DavSanchez DavSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajrohanyadav rajrohanyadav force-pushed the fix-coveralls-workflow-step-failures branch from b435fb3 to 06a5dad Compare November 7, 2024 10:58
@rajrohanyadav rajrohanyadav merged commit 98ee774 into master Nov 7, 2024
21 of 23 checks passed
@rajrohanyadav rajrohanyadav deleted the fix-coveralls-workflow-step-failures branch November 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants