-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-291019 add fips compliant package builds #530
Conversation
4cf7abe
to
0e1d24f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks just left a couple of comments, i see that there is no workflow to run this neither push the artifacts. i guess that it would be following prs ?
Thanks for the comments. I believe goreleaser takes care of pushing the artifacts to the release from the runner (as happening until now for this repo). I don't know if we need to publish these to S3. So, there would be no changes to the way packages are published, just two additional packages with be created for each release. |
4f570ea
to
40154bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments
813fd4a
to
e474ee8
Compare
e474ee8
to
343bc3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, GOOD JOB!
What?
Adds compilation and packaging of FIPS compliant packages using
boringcrypto
Why?
Many customers can only use FIPS compliant packages in their environments
How?