Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix check fd #56000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: fix check fd #56000

wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

Fixed: #55983

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 26, 2024
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use GetValidatedFd() function to get the file descriptor, and throw the error according to it:

v8::Maybe<int32_t> GetValidatedFd(Environment* env,

@theanarkh
Copy link
Contributor Author

GetValidatedFd call util::DetermineSpecificErrorType to get the the error message.

test/parallel/test-fs-stat.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (7a7c2b3) to head (83ff67c).
Report is 301 commits behind head on main.

Files with missing lines Patch % Lines
src/util.cc 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56000      +/-   ##
==========================================
- Coverage   88.41%   87.96%   -0.46%     
==========================================
  Files         652      656       +4     
  Lines      186878   188317    +1439     
  Branches    36061    35976      -85     
==========================================
+ Hits       165236   165652     +416     
- Misses      14895    15838     +943     
- Partials     6747     6827      +80     
Files with missing lines Coverage Δ
src/util.cc 87.16% <71.42%> (-0.24%) ⬇️

... and 230 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.fstat results in an abort with some arguments
6 participants