-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix check fd #56000
base: main
Are you sure you want to change the base?
src: fix check fd #56000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use GetValidatedFd()
function to get the file descriptor, and throw the error according to it:
Line 807 in 4f62ab5
v8::Maybe<int32_t> GetValidatedFd(Environment* env, |
|
37b5cac
to
d63fd86
Compare
d63fd86
to
9a427e1
Compare
9a427e1
to
83ff67c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56000 +/- ##
==========================================
- Coverage 88.41% 87.96% -0.46%
==========================================
Files 652 656 +4
Lines 186878 188317 +1439
Branches 36061 35976 -85
==========================================
+ Hits 165236 165652 +416
- Misses 14895 15838 +943
- Partials 6747 6827 +80
|
Fixed: #55983
make -j4 test
(UNIX), orvcbuild test
(Windows) passes