Egress policy support #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vareti
force-pushed
the
EgressPolicySupport
branch
2 times, most recently
from
e9274e2
to
0f12b7d
Compare
vareti
commented
May 15, 2018
| glog.Errorf("finding namespaces from selector label %s failed: %v", peer.NamespaceSelector.String(), err) | ||
| return err | ||
|
|
||
| if peer.NamespaceSelector != nil { |
There was a problem hiding this comment.
can we move this logic inside findNamespacesWithLabel function? similar to createPgAddVports
…r allow traffic for ipcidr block
vareti
force-pushed
the
EgressPolicySupport
branch
from
1651b34
to
da5bf9d
Compare
vareti
force-pushed
the
EgressPolicySupport
branch
from
df703d0
to
136b7cb
Compare
|
addresses in #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.