o1vm/mips: allocate correctly the inverse column

o1-labs · Nov 21, 2024 · b45339e · b45339e
1 parent 092352a
commit b45339e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/o1vm/src/interpreters/mips/constraints.rs b/o1vm/src/interpreters/mips/constraints.rs
@@ -227,7 +227,7 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
             unsafe { self.test_zero(x, pos) }
         };
         let x_inv_or_zero = {
-            let pos = self.alloc_scratch();
+            let pos = self.alloc_scratch_inverse();
             self.variable(pos)
         };
         // If x = 0, then res = 1 and x_inv_or_zero = 0

diff --git a/o1vm/src/interpreters/mips/witness.rs b/o1vm/src/interpreters/mips/witness.rs
@@ -329,15 +329,15 @@ impl<Fp: Field, PreImageOracle: PreImageOracleT> InterpreterEnv for Env<Fp, PreI
 
     fn is_zero(&mut self, x: &Self::Variable) -> Self::Variable {
         // write the result
-        let pos = self.alloc_scratch();
-        let res = if *x == 0 { 1 } else { 0 };
-        self.write_column(pos, res);
+        let res = {
+            let pos = self.alloc_scratch();
+            unsafe { self.test_zero(x, pos) }
+        };
         // write the non deterministic advice inv_or_zero
+        let pos = self.alloc_scratch_inverse();
         if *x == 0 {
-            let pos = self.alloc_scratch();
             self.write_field_column(pos, Fp::zero());
         } else {
-            let pos = self.alloc_scratch_inverse();
             self.write_field_column(pos, Fp::from(*x));
         };
         // return the result
@@ -354,11 +354,10 @@ impl<Fp: Field, PreImageOracle: PreImageOracleT> InterpreterEnv for Env<Fp, PreI
             self.write_column(pos, is_zero);
             is_zero
         };
+        let pos = self.alloc_scratch_inverse();
         if to_zero_test == Fp::zero() {
-            let pos = self.alloc_scratch();
             self.write_field_column(pos, Fp::zero());
         } else {
-            let pos = self.alloc_scratch_inverse();
             self.write_field_column(pos, to_zero_test);
         };
         res