Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: login auth type mail options #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

galviset
Copy link

Fixed #5, mails not being sent if there is SMTP authentification in the backend configuration.

Copy link
Contributor

@alexskr alexskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I assume it works in your environment.

This PR is based on lirmm's fork of ontologies_linked_data which includes refactored notification so unit tests would not pass until ncbo#148 gets merged

Our options are:

  1. Merge Refactor: notifications  ncbo/ontologies_linked_data#148
  2. disable unit test until PR is merged
  3. change 'LinkedData::Utils::Notifier' to 'LinkedData::Utils::Notifications'

I lean towards the second option. @mdorf, what is your preference?

@syphax-bouazzouni
Copy link
Contributor

hi @galviset, I think the easiest solution here, would to be remove the test in this PR.
in the case of NCBO (@mdorf , @alexskr ), I updated directly ncbo#148 to include this fix.

@alexskr
Copy link
Contributor

alexskr commented Dec 1, 2023

@syphax-bouazzouni thanks for updating refactored notifications PR in the NCBO fork. We plan on merging it in the near future so this PR would be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API email notifications SMTPAuthenticationError
3 participants