Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #348

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 9, 2023

CR Link

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer, react-helmet, & react-redux to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4592803) 87.72% compared to head (6024ac6) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files         140      140           
  Lines        2948     2948           
  Branches      735      735           
=======================================
  Hits         2586     2586           
  Misses        361      361           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m merged commit a475680 into master Aug 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants