Upgrade golang.org/x/net from v0.7.0 to v0.31.0 and update the buildx build just use one Dockerfile #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and google.golang.org/protobuf from v1.28.1 to v1.35.2; update the buildx build just use one Dockerfile
furykerry
reviewed
Nov 21, 2024
| golang.org/x/sys v0.5.0 // indirect | ||
| golang.org/x/term v0.5.0 // indirect | ||
| golang.org/x/text v0.7.0 // indirect | ||
| golang.org/x/sys v0.27.0 // indirect |
There was a problem hiding this comment.
these are indirect dependency required by package e.g. client-go, so it is not appropriate to change the indirect dependency. if the dependency version do bother you, you should upgrade the client-go package. the k8s and gateway-api dependency had been upgraded recently(#237), yet the changes are not release yet. so further upgrade can be schedule for future, can you submit an issue, about the package requirement in your environment?
There was a problem hiding this comment.
- fix the vulnerability of golang.org/x/net CVE link: https://avd.aquasec.com/nvd/2022/cve-2022-27664/
- fix the vulnerability of golang.org/x/text CVE link: https://avd.aquasec.com/nvd/2021/cve-2021-38561/
| # Build | ||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go | ||
| RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -installsuffix cgo -a -o manager main.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and google.golang.org/protobuf from v1.28.1 to v1.35.2; update the buildx build just use one Dockerfile
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews