Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicated Yves Rocher #10150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

urbalazs
Copy link

No description provided.

@Snowysauce Snowysauce added the fix data Need to cleanup the data in OSM after this is released label Nov 18, 2024
@Snowysauce
Copy link
Collaborator

I agree that the duplicate entries should be merged, but an overpass-turbo query for "Yves Rocher" indicates that the merge should be in the opposite direction than what's proposed in this PR. As of this writing, there are 935 instances of "Yves Rocher" with shop=beauty (plus however many exist for the China, Taiwan, and Hong Kong sister entries) and 690 instances of "Yves Rocher" with shop=cosmetics in OSM.

@Snowysauce Snowysauce added the needs discussion Waiting for other contributors to voice their opinion label Nov 26, 2024
@urbalazs
Copy link
Author

You are right based on the numbers. But Yves Rocher is a cosmetics shop. The amount of wrong entries come from the duplicated presets: shop=beauty is before shop=cosmetics (in alphabetical order), so most users choose the first one. I would like to solve this issue with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released needs discussion Waiting for other contributors to voice their opinion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants