Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated.netapp): add hold snapshot feature #13888

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(dedicated.netapp): add hold snapshot feature #13888

wants to merge 2 commits into from
+105 −17

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented Oct 31, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15710
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Add the feature to save an automatic snapshot :
image

-> Snapshot service has been move and rename from restore snapshot component but did not change.

Related

  • CMT-18518

@qpavy qpavy requested a review from a team as a code owner October 31, 2024 14:20
feat(dedicated.netapp): add hold snapshot feature
cdb3792 
ref: MANAGER-15710

Signed-off-by: Quentin Pavy <[email protected]>
@qpavy qpavy changed the base branch from master to develop October 31, 2024 14:29
anooparveti
anooparveti previously approved these changes Nov 4, 2024
View reviewed changes
sachinrameshn
sachinrameshn previously approved these changes Nov 4, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@darsene darsene darsene approved these changes

@anooparveti anooparveti anooparveti left review comments

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qpavy @anooparveti @darsene @sachinrameshn