Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1051 Drop astype tests for Mac arm for float128 and complex256 #1057

Merged
merged 12 commits into from
Nov 27, 2024

Conversation

loicdiridollou
Copy link
Contributor

@loicdiridollou loicdiridollou marked this pull request as draft November 26, 2024 12:33
@loicdiridollou loicdiridollou marked this pull request as ready for review November 26, 2024 22:46
@loicdiridollou
Copy link
Contributor Author

Needed to let poetry choose the right version of tables, wondering if it is okay, at least we will need that to move to supporting python3.13.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the version of tables

pyproject.toml Outdated
@@ -47,7 +47,7 @@ black = ">=23.3.0"
isort = ">=5.12.0"
openpyxl = ">=3.0.10"
# for tables, MacOS gives random CI failures on 3.9.2
tables = { version = "==3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
tables = { version = ">=3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 3.10.1 is out, and it was what was used in the tests, so changing this from 3.9.2 to 3.10.1 is warranted.

loicdiridollou and others added 6 commits November 27, 2024 13:33
…dev#1050)

* GH1049 Deprecate Index and Grouper methods for migration to 2.0

* GH1049 Deprecate use_nullable_dtypes in read_parquet
…andas-dev#1054)

* GH1053 @ for DataFrame, eval in place for DataFrame, test migrations

* Formatting and spelling

* GH1053 PR Feedback

* GH1053 Formatting
…1044)

* Update _typing.pyi: add "cross" option to JoinHow

* Removed "cross" option from JoinHow and added it back to MergeHow

* Replaced JoinHow with MergeHow in frame.join

* Added a test for join "how"

* Update test_frame.py: used check(assert_type pattern in unit test

* Update test_frame.py

Fix formatting
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit b6ae6e8 into pandas-dev:main Nov 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astype tests failing for f16, float128, c32 and complex256 on MacOS arm64 platforms
4 participants