-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH1051 Drop astype tests for Mac arm for float128 and complex256 #1057
Conversation
Needed to let poetry choose the right version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update the version of tables
pyproject.toml
Outdated
@@ -47,7 +47,7 @@ black = ">=23.3.0" | |||
isort = ">=5.12.0" | |||
openpyxl = ">=3.0.10" | |||
# for tables, MacOS gives random CI failures on 3.9.2 | |||
tables = { version = "==3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4 | |||
tables = { version = ">=3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 3.10.1 is out, and it was what was used in the tests, so changing this from 3.9.2 to 3.10.1 is warranted.
…dev#1050) * GH1049 Deprecate Index and Grouper methods for migration to 2.0 * GH1049 Deprecate use_nullable_dtypes in read_parquet
…andas-dev#1054) * GH1053 @ for DataFrame, eval in place for DataFrame, test migrations * Formatting and spelling * GH1053 PR Feedback * GH1053 Formatting
…1044) * Update _typing.pyi: add "cross" option to JoinHow * Removed "cross" option from JoinHow and added it back to MergeHow * Replaced JoinHow with MergeHow in frame.join * Added a test for join "how" * Update test_frame.py: used check(assert_type pattern in unit test * Update test_frame.py Fix formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @loicdiridollou
f16
,float128
,c32
andcomplex256
on MacOS arm64 platforms #1051assert_type()
to assert the type of any return value