Use CharField & Remove "Banner" #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm03
approved these changes
Nov 2, 2023
joyliu-q
pushed a commit
that referenced
this pull request
Nov 9, 2023
* attempt to setup announcements * first pass * add populate command * oops * Use CharField & Remove "Banner" (#166) * fix(announcement): use char instead of integer for announcement_type * lint: lol I didn't even have flake8 installed * update Announcement serializer * unpin black version + lint * isort --------- Co-authored-by: Rohan Moniz <[email protected]> * add filtering on product and end time * add test cases * lint * migration * address comments * more validation --------- Co-authored-by: Eunsoo Shin <[email protected]> Co-authored-by: Eunsoo Shin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Banner" is unnecessary, we will only use "ISSUE" and "NOTICE" but leave space for extensibility later on.
Minor change to use CharField for clarity, frontend would prefer using strings over integers to distinguish the type of announcements.