Recommend enabling auto_explain.log_timing #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msakrejda
reviewed
May 10, 2024
msakrejda
approved these changes
May 10, 2024
|
Holding off on merging so Lukas has time to review the change. If we want to provide more performance-focused guidance, we could also suggest setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our production database we see around a 5% overhead from enabling
auto_explain.log_timing. Since it's difficult to tell which parts of a complex query plan were actually slow without the per-node timing information, we've decided it's worth the overhead. As such, this PR updates the documentation to recommend enabling the setting while noting that users should judge for themselves if the overhead is worth it.This PR also adds a
Calloutcomponent that's been copied from the main app. Since we don't currently include Tailwind in the marketing site, this version has its styles inlined.