Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new GRAVITY_RESTORED_MESSAGE message type #2122

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add new GRAVITY_RESTORED_MESSAGE message type #2122

wants to merge 2 commits into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 23, 2024

What does this implement/fix?

image

Accompanying pi-hole/pi-hole#5818

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team November 23, 2024 08:43
@DL6ER DL6ER mentioned this pull request Nov 23, 2024
Open
5 tasks
@DL6ER DL6ER force-pushed the new/GRAVITY_RESTORED_MESSAGE branch from 0c97860 to 291cce6 Compare November 23, 2024 10:27
rdwebdesign
rdwebdesign requested changes Nov 23, 2024
View reviewed changes
src/database/message-table.c Outdated Show resolved Hide resolved
src/database/message-table.c Outdated Show resolved Hide resolved
@DL6ER @rdwebdesign
Apply suggestions from code review (status coloring)
e5597ef 
Co-authored-by: RD WebDesign <[email protected]>
Signed-off-by: Dominik <[email protected]>
Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER force-pushed the new/GRAVITY_RESTORED_MESSAGE branch from cd11cc2 to e5597ef Compare November 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign Awaiting requested review from rdwebdesign

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Pi-hole v6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DL6ER @rdwebdesign